[Webkit-unassigned] [Bug 75156] [EFL] Add the Vibration API to the WebKit-EFL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75156


Ryuan Choi <ryuan.choi at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ryuan.choi at samsung.com




--- Comment #3 from Ryuan Choi <ryuan.choi at samsung.com>  2011-12-22 19:36:53 PST ---
(From update of attachment 120422 [details])
> Source/WebKit/efl/CMakeListsEfl.txt:135
> +IF (ENABLE_VIBRATION)
> +  LIST(APPEND WebKit_SOURCES
> +    efl/WebCoreSupport/VibratorClientEfl.cpp
> +    efl/ewk/ewk_vibrator.cpp
> +  )
> +ENDIF ()

If I am right, our CMake files use 4 spaces indentation without this file.

I'm not sure whether we need to fix this file because of history.
If we need, I'll create a bug.

Anyway, I like that this patch follow our CMake indentation.

> Source/WebKit/efl/WebCoreSupport/VibratorClientEfl.cpp:33
> +{

how about adding ASSERT(m_view); ?

> Source/WebKit/efl/WebCoreSupport/VibratorClientEfl.h:20
> +*/
> +
> +

IMO, one empty line is enough.

> Source/WebKit/efl/ewk/ewk_view.cpp:614
> +#if ENABLE(VIBRATION)
> +    pageClients.vibratorClient = new WebCore::VibratorClientEfl(smartData->self);

Who remove vibratorClient ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.