[Webkit-unassigned] [Bug 73971] [Chromium] WebFrame should have an interface to invoke spellchecking in arbitrarily

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73971


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #118994|review?                     |review-
               Flag|                            |




--- Comment #6 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-12-16 16:40:47 PST ---
(From update of attachment 118994)
View in context: https://bugs.webkit.org/attachment.cgi?id=118994&action=review

> Source/WebKit/chromium/public/WebFrame.h:421
> +    virtual void requestTextChecking(const WebNode&) = 0;

maybe this should take a WebElement instead?

from the chrome side, how do you know which WebFrame to call this
function on?  what if the focused editable content is actually in
a different frame?  are you using WebView::focusedFrame() for that?

> Source/WebKit/chromium/public/WebNode.h:113
> +    WEBKIT_EXPORT WebElement rootEditableElement() const;

it seems wrong for WebNode to know about elements.  maybe this should be a function
on WebElement?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.