[Webkit-unassigned] [Bug 73971] [Chromium] WebFrame should have an interface to invoke spellchecking in arbitrarily

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73971





--- Comment #7 from Shinya Kawanaka <shinyak at chromium.org>  2011-12-18 20:55:41 PST ---
(In reply to comment #6)
> (From update of attachment 118994 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=118994&action=review
> 
> > Source/WebKit/chromium/public/WebFrame.h:421
> > +    virtual void requestTextChecking(const WebNode&) = 0;
> 
> maybe this should take a WebElement instead?

Thanks. It seems better.

> 
> from the chrome side, how do you know which WebFrame to call this
> function on?  what if the focused editable content is actually in
> a different frame?  are you using WebView::focusedFrame() for that?

Yes. Does it have any problem? If so, please let me know.

> 
> > Source/WebKit/chromium/public/WebNode.h:113
> > +    WEBKIT_EXPORT WebElement rootEditableElement() const;
> 
> it seems wrong for WebNode to know about elements.  maybe this should be a function
> on WebElement?

When considering TextNode, it seems natural that it knows rootEditableElement, I think.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.