[Webkit-unassigned] [Bug 73971] [Chromium] WebFrame should have an interface to invoke spellchecking in arbitrarily

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73971


Shinya Kawanaka <shinyak at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |shinyak at chromium.org




--- Comment #5 from Shinya Kawanaka <shinyak at chromium.org>  2011-12-13 03:30:51 PST ---
> This looks a lot like the WebSpellCheckClient::requestCheckingOfText method,
> although I realize that they are totally different.  It seems unfortunate
> for those two methods, which are different, to have such similar names.

The method of WebspellCheckClient is used to request spellchecking from WebKit to chromium, and my method is used to request spellchecking from chromium to WebKit. The former method is just to spellchecking, and the latter method does spellchecking and adding misspelling markers.

> This seems to be a fairly high-level function. 

Yeah, I'm now thinking so, too... So now I changed the code to give a node to the method. 

> It appears to initiate a
> spelling and grammar check of the selected editable text.  What if there
> is no selection?  Does it spell check anything in that case?  What if
> there is nothing editable in the current selection?  Maybe answering
> some of these questions could help us consider a better name for this
> function?

Actually what I want to solve by this patch is:
http://code.google.com/p/chromium/issues/detail?id=21225
Just for your information, I uploaded Chromium side patch in
http://codereview.chromium.org/8907016/

So what I want to do in this function is to spellcheck some area in the document (not just selected text).
If there is no node to spellcheck, this method should return immediately.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.