[Webkit-unassigned] [Bug 73039] [Web Intents] Flagged-off implementation of an intent tag for registration.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73039





--- Comment #29 from Adam Barth <abarth at webkit.org>  2011-12-05 09:52:27 PST ---
(From update of attachment 116784)
View in context: https://bugs.webkit.org/attachment.cgi?id=116784&action=review

> Source/WebCore/html/HTMLAttributeNames.in:95
> +disposition

This is fine to have unconditionally.  It's only visible internally to WebCore, not to the platform.

> Source/WebCore/html/HTMLIntentElement.cpp:43
> +inline HTMLIntentElement::HTMLIntentElement(const QualifiedName& tagName, Document* document)

Why "inline"?  It's not declared inline in the header.

> Source/WebCore/html/HTMLIntentElement.cpp:54
> +void HTMLIntentElement::insertedIntoDocument()

Do we need a notification when this element is removed from the document?  I guess there's no way to unregister an intent once you've registered it?  Do we need some kind of max-age on intents to avoid broken intent links?

> Source/WebCore/html/HTMLIntentElement.cpp:59
> +    if (!document()->frame() || !document()->frame()->loader()->client())
> +        return;

There's no need to null check the loader()->client().  It's never null.

> Source/WebCore/html/HTMLIntentElement.cpp:62
> +    document()->frame()->loader()->client()->registerIntentService(
> +        getAttribute(actionAttr), getAttribute(typeAttr), getAttribute(hrefAttr), getAttribute(titleAttr), getAttribute(dispositionAttr));

I think we can use fastGetAttribute for these.

> Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp:1622
> +        const WTF::String& action,

Should we add a "using WTF::String" to this file?

> Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp:1627
> +    WebURL url = m_webFrame->document().completeURL(href);

It seems like WebCore should call completeURL and "href" should be a KURL.

> Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp:1628
> +    if (m_webFrame->client()) {

Prefer early return.

> Source/WebKit/chromium/src/WebIntentServiceInfo.cpp:47
> +      m_disposition(disposition) { }

{ } should be on separate lines.  Also, the "," should be aligned below the ":".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.