[Webkit-unassigned] [Bug 73039] [Web Intents] Flagged-off implementation of an intent tag for registration.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73039





--- Comment #30 from Greg Billock <gbillock at google.com>  2011-12-06 12:53:35 PST ---
(From update of attachment 116784)
View in context: https://bugs.webkit.org/attachment.cgi?id=116784&action=review

>> Source/WebCore/html/HTMLAttributeNames.in:95
>> +disposition
> 
> This is fine to have unconditionally.  It's only visible internally to WebCore, not to the platform.

OK, sounds good.

>> Source/WebCore/html/HTMLIntentElement.cpp:43
>> +inline HTMLIntentElement::HTMLIntentElement(const QualifiedName& tagName, Document* document)
> 
> Why "inline"?  It's not declared inline in the header.

Got rid of this.

>> Source/WebCore/html/HTMLIntentElement.cpp:54
>> +void HTMLIntentElement::insertedIntoDocument()
> 
> Do we need a notification when this element is removed from the document?  I guess there's no way to unregister an intent once you've registered it?  Do we need some kind of max-age on intents to avoid broken intent links?

I don't think so. This is part of the larger problem around the fact that it's up to the UA to detect when a page used to have an intent tag and no longer does. A page can stop handling intents at any time, but the UA may not become aware of it until it loads the page to respond to an intent invocation.

>> Source/WebCore/html/HTMLIntentElement.cpp:59
>> +        return;
> 
> There's no need to null check the loader()->client().  It's never null.

OK, thanks. Done.

>> Source/WebCore/html/HTMLIntentElement.cpp:62
>> +        getAttribute(actionAttr), getAttribute(typeAttr), getAttribute(hrefAttr), getAttribute(titleAttr), getAttribute(dispositionAttr));
> 
> I think we can use fastGetAttribute for these.

Done.

>> Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp:1622
>> +        const WTF::String& action,
> 
> Should we add a "using WTF::String" to this file?

There's an implicit using (other code is just using "String", so I changed this to do likewise.

>> Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp:1627
>> +    WebURL url = m_webFrame->document().completeURL(href);
> 
> It seems like WebCore should call completeURL and "href" should be a KURL.

Done.

>> Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp:1628
>> +    if (m_webFrame->client()) {
> 
> Prefer early return.

Done.

>> Source/WebKit/chromium/src/WebIntentServiceInfo.cpp:47
>> +      m_disposition(disposition) { }
> 
> { } should be on separate lines.  Also, the "," should be aligned below the ":".

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.