[Webkit-unassigned] [Bug 31500] webkit-patch land hangs if svn prompts for credentials

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31500





--- Comment #23 from Daniel Bates <dbates at webkit.org>  2011-04-17 15:24:58 PST ---
(In reply to comment #21)
> (From update of attachment 89963 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=89963&action=review
> [...]
> > Tools/Scripts/webkitpy/common/net/credentials.py:151
> > -            password = getpass.getpass("%s password for %s: " % (self.host, username))
> > +            password = User.prompt_password("%s password for %s: " % (self.host, username))
> 
> This should really get the user object off the tool so we can mock it out during testing.

Currently, the tool isn't passed to the Credentials object.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.