[Webkit-unassigned] [Bug 31500] webkit-patch land hangs if svn prompts for credentials

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31500





--- Comment #24 from Daniel Bates <dbates at webkit.org>  2011-04-17 15:55:08 PST ---
(In reply to comment #22)
> (From update of attachment 89963 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=89963&action=review
> 
> > Tools/Scripts/webkitpy/common/checkout/scm.py:384
> > +        find_output = run_command(find_args, cwd=home_directory).rstrip()
> 
> Sad.  Why not move this onto some helper object which both SVN and Git share (which could have an Executive).  Or maybe Git should have an SVN object pointing to its git-svn checkout?

Will change to be a mixin class.

> 
> > Tools/Scripts/webkitpy/common/checkout/scm.py:848
> > +                return self._commit_on_branch(message, 'HEAD', username=username, password=password)
> 
> Do we really want to pass these around everywhere? 

Notice, _commit_on_branch() is specific to the Git code path. It is called from Git.commit_with_message() and both this method and Git._commit_on_branch() call Git.push_local_commits_to_server() which needs these credentials so as to pass to git svn dcommit.

We could look to hoist the call to Git.push_local_commits_to_server() from  Git._commit_on_branch() into Git.commit_with_message() so that we don't have to pass the username and password arguments to Git.commit_with_message(). At the moment I'm unsure how best to do this given the current structure of Git._commit_on_branch(). Further investigation is needed.

> Does SVN?  Or does it store it on the SVN object?

All of the logic for committing with SVN is contained in SVN.commit_with_message(). Hence, we don't see the same passing of these arguments to sub-functions as we do with the Git code path.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.