[Webkit-unassigned] [Bug 31500] webkit-patch land hangs if svn prompts for credentials

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31500





--- Comment #22 from Eric Seidel <eric at webkit.org>  2011-04-17 15:09:12 PST ---
(From update of attachment 89963)
View in context: https://bugs.webkit.org/attachment.cgi?id=89963&action=review

> Tools/Scripts/webkitpy/common/checkout/scm.py:384
> +        find_output = run_command(find_args, cwd=home_directory).rstrip()

Sad.  Why not move this onto some helper object which both SVN and Git share (which could have an Executive).  Or maybe Git should have an SVN object pointing to its git-svn checkout?

> Tools/Scripts/webkitpy/common/checkout/scm.py:848
> +                return self._commit_on_branch(message, 'HEAD', username=username, password=password)

Do we really want to pass these around everywhere?  Does SVN?  Or does it store it on the SVN object?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.