[Webkit-unassigned] [Bug 31500] webkit-patch land hangs if svn prompts for credentials

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31500


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89963|review?                     |review+
               Flag|                            |




--- Comment #21 from Adam Barth <abarth at webkit.org>  2011-04-17 14:36:39 PST ---
(From update of attachment 89963)
View in context: https://bugs.webkit.org/attachment.cgi?id=89963&action=review

Look beautiful.

> Tools/Scripts/webkitpy/common/net/credentials.py:151
> -            password = getpass.getpass("%s password for %s: " % (self.host, username))
> +            password = User.prompt_password("%s password for %s: " % (self.host, username))

This should really get the user object off the tool so we can mock it out during testing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.