[Webkit-unassigned] [Bug 58027] Avoid leaking document when leaving google.com due to geolocation permission request

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58027





--- Comment #4 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-04-08 05:08:13 PST ---
(In reply to comment #3)
> (From update of attachment 88606 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=88606&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        In fatalErrorOccurred (which is called on cancellation), the notifier
> 
> What do you mean by 'cancellation'? Can you elaborate in the bug exactly what the problem is? Presumably it's not unique to google.com?

Reloading the page or loading another one, leaks document() probably due to event holding a ref to document (presumable TargetEvent).

It probably happens on other pages as well (using watchPosition?), but I didn't manage to trigger the leak with my own simple tests, and debugging what exactly is happening on google.com is pretty hard due to the obscured javascript code.

> 
> > Source/WebCore/ChangeLog:18
> > +
> 
> Can you add a test for this? If not, you should explain here why not.

The test can only work for ports using the PREEMPT_... build flag, and I am not sure now to actually test this, so any help is appreciated. Testing it is hard due to the reloading, plus the fact that I cannot AFAIK count the document references from LayoutTestController.

> > Source/WebCore/page/Geolocation.cpp:342
> > +    m_requestsAwaitingCachedPosition.remove(notifier);
> 
> I think that the only way for a notifier to be in this list when it encounters a fatal error is when Geolocation::reset() is called. Is this what you're protecting against?

I added this one for completions sake. It can be left out.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.