[Webkit-unassigned] [Bug 58027] Avoid leaking document when leaving google.com due to geolocation permission request

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 8 04:35:28 PDT 2011


--- Comment #3 from Steve Block <steveblock at google.com>  2011-04-08 04:35:28 PST ---
(From update of attachment 88606)
View in context: https://bugs.webkit.org/attachment.cgi?id=88606&action=review

> Source/WebCore/ChangeLog:11
> +        In fatalErrorOccurred (which is called on cancellation), the notifier

What do you mean by 'cancellation'? Can you elaborate in the bug exactly what the problem is? Presumably it's not unique to google.com?

> Source/WebCore/ChangeLog:18
> +

Can you add a test for this? If not, you should explain here why not.

> Source/WebCore/page/Geolocation.cpp:342
> +    m_requestsAwaitingCachedPosition.remove(notifier);

I think that the only way for a notifier to be in this list when it encounters a fatal error is when Geolocation::reset() is called. Is this what you're protecting against?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list