[Webkit-unassigned] [Bug 58027] Avoid leaking document when leaving google.com due to geolocation permission request

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58027





--- Comment #5 from Steve Block <steveblock at google.com>  2011-04-08 06:19:15 PST ---
(From update of attachment 88606)
View in context: https://bugs.webkit.org/attachment.cgi?id=88606&action=review

>>> Source/WebCore/ChangeLog:11
>>> +        In fatalErrorOccurred (which is called on cancellation), the notifier
>> 
>> What do you mean by 'cancellation'? Can you elaborate in the bug exactly what the problem is? Presumably it's not unique to google.com?
> 
> Reloading the page or loading another one, leaks document() probably due to event holding a ref to document (presumable TargetEvent).
> 
> It probably happens on other pages as well (using watchPosition?), but I didn't manage to trigger the leak with my own simple tests, and debugging what exactly is happening on google.com is pretty hard due to the obscured javascript code.

Do you see this only on Chromium? I think it would be good to understand a little more about the problem before we make the fix. The Geolocation callbacks don't ref their ScriptExecutionContext, so I don't see how removing this notifier from this list will avoid a leak. Presumably the Geolocation object is leaked too?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.