[Webkit-unassigned] [Bug 57717] Convert use of raw pointers to RefPtr in using Cairo

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 4 07:05:00 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=57717





--- Comment #10 from Martin Robinson <mrobinson at webkit.org>  2011-04-04 07:04:59 PST ---
(From update of attachment 88012)
View in context: https://bugs.webkit.org/attachment.cgi?id=88012&action=review

>> Source/WebCore/platform/graphics/cairo/ContextShadowCairo.cpp:82
>> +    return scratchBuffer.get();
> 
> Um.  This isn't going to work, or?  I think you want to return a PassRefPtr here.

I think it should work, since scratchBuffer is a static global. This patch should probably rename "scratchBuffer" to something like "gScratchBuffer" to make it clear that it's static though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list