[Webkit-unassigned] [Bug 57717] Convert use of raw pointers to RefPtr in using Cairo

Sun Apr 3 22:59:10 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=57717

Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88012|review?                     |review-
               Flag|                            |

--- Comment #9 from Eric Seidel <eric at webkit.org>  2011-04-03 22:59:10 PST ---
(From update of attachment 88012)
View in context: https://bugs.webkit.org/attachment.cgi?id=88012&action=review

This patch makes my heart sing!  Unfortunately I think it also will make WebCore crash (in the one case I pointed out.

> Source/WebCore/platform/graphics/cairo/ContextShadowCairo.cpp:82
> +    scratchBuffer = adoptRef(cairo_image_surface_create(CAIRO_FORMAT_ARGB32, width, height));
> +    return scratchBuffer.get();

Um.  This isn't going to work, or?  I think you want to return a PassRefPtr here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.