[Webkit-unassigned] [Bug 57717] Convert use of raw pointers to RefPtr in using Cairo
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 4 08:55:03 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=57717
--- Comment #11 from Joone Hur <joone at kldp.org> 2011-04-04 08:55:03 PST ---
(In reply to comment #10)
> (From update of attachment 88012 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=88012&action=review
>
> >> Source/WebCore/platform/graphics/cairo/ContextShadowCairo.cpp:82
> >> + return scratchBuffer.get();
> >
> > Um. This isn't going to work, or? I think you want to return a PassRefPtr here.
>
> I think it should work, since scratchBuffer is a static global. This patch should probably rename "scratchBuffer" to something like "gScratchBuffer" to make it clear that it's static though.
This code works well without any crash.
http://www.w3schools.com/css3/tryit.asp?filename=trycss3_box-shadow
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list