[Webkit-unassigned] [Bug 45522] Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45522





--- Comment #7 from Peter Kasting <pkasting at google.com>  2010-09-10 10:50:08 PST ---
(From update of attachment 67153)
View in context: https://bugs.webkit.org/attachment.cgi?id=67153&action=prettypatch

> WebKit/chromium/src/WebViewImpl.cpp:1485
> +        view->setPageZoomFactor(1.0f);
It seems slightly strange to me that we're removing a constraint on "only use text zoom or page zoom at one time" and yet this still forces the other zoom level to 1 every time one zoom level is set.  It seems like it would be better to either rely on the port to do this if it wants zooming one thing to reset the other, or make the APIs take both a text and page zoom value simultaneously (so that ports must specify what they mean, and we avoid doing two style recalcs in a row).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.