[Webkit-unassigned] [Bug 45522] Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45522





--- Comment #8 from Darin Adler <darin at apple.com>  2010-09-10 10:56:11 PST ---
(In reply to comment #7)
> It seems slightly strange to me that we're removing a constraint on "only use text zoom or page zoom at one time" and yet this still forces the other zoom level to 1 every time one zoom level is set. It seems like it would be better to either rely on the port to do this if it wants zooming one thing to reset the other, or make the APIs take both a text and page zoom value simultaneously (so that ports must specify what they mean, and we avoid doing two style recalcs in a row).

The code you quoted is from inside the Chromium port, and we do rely on the port to do this!

This patch preserves the WebKit API for the various ports. You suggestions point to a direction for improving Chromium’s WebKit API and could be done in a different patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.