[Webkit-unassigned] [Bug 45522] Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45522


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com




--- Comment #6 from Darin Adler <darin at apple.com>  2010-09-10 09:53:02 PST ---
(In reply to comment #5)
> > WebKit/chromium/src/FrameLoaderClientImpl.cpp:1401
> > +    bool zoomTextOnly = m_webFrame->viewImpl();
> viewImpl is of type WebViewImpl*, but you are storing it in a 'bool'.  i think this is going to force zoomTextOnly to always be true.
> 
> i think you meant to write m_webFrame->viewImpl()->zoomTextOnly().

Good catch! I missed that one!

> > WebKit/chromium/src/WebViewImpl.cpp:1494
> > +        m_page->setNeedsRecalcStyleInAllFrames();
> why isn't this a byproduct of calling set{Text,Page}ZoomFactor?  isn't unfortunate for WebKit layers to need to understand when to call setNeedsRecalcStyleInAllFrames?

Not sure if you noticed, but I made the same comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.