[Webkit-unassigned] [Bug 44759] [EFL] Add custom network resource handler

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44759





--- Comment #5 from Antonio Gomes <tonikitoo at webkit.org>  2010-09-01 10:25:09 PST ---

> Because the base class FrameLoaderClient was defined in this file,  moreover there is no file named FrameLoaderClient.cpp. I can do these methods inline inside FrameLoaderClient.h, do you think is it better ?

WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.* ?

> > > WebCore/loader/FrameLoaderClient.h:271
> > > +#if PLATFORM(EFL)
> > > +        virtual bool shouldHandleScheme(const String&);
> > > +        virtual void* handleScheme(const KURL, String&, size_t*);
> > > +#endif
> > Why would these functions be EFL-specific?  I don't think these make sense >here.
> 
> The others ports don't need it, they can do that using their own network library
> 
> > 
> > > WebCore/platform/network/soup/ResourceHandleSoup.cpp:131
> > > +#if PLATFORM(EFL)
> > > +static bool startPersonalHandler(ResourceHandle* handle, KURL url);
> > > +#endif
> > Adding EFL ifdefs to ResourceHandleSoup isn't the right approach.
> 

Personal x Custom (?)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.