[Webkit-unassigned] [Bug 44759] [EFL] Add custom network resource handler

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44759





--- Comment #6 from Flavio Ceolin <flavio.ceolin at profusion.mobi>  2010-09-07 08:06:12 PST ---
(In reply to comment #5)
> > Because the base class FrameLoaderClient was defined in this file,  moreover there is no file named FrameLoaderClient.cpp. I can do these methods inline inside FrameLoaderClient.h, do you think is it better ?
> 
> WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.* ?
> 
If i don't implement those methods in the FrameLoader.cpp I have some undefined references as you can see below:

WebCore/libwebcore_efl.so.0.1.0: undefined reference to `WebCore::FrameLoaderClient::shouldHandleScheme(WTF::String const&)'
WebCore/libwebcore_efl.so.0.1.0: undefined reference to `WebCore::FrameLoaderClient::handleScheme(WebCore::KURL, WTF::String&, unsigned int*)'

> > > > WebCore/loader/FrameLoaderClient.h:27
> > > > +#if PLATFORM(EFL)
> > > > +        virtual bool shouldHandleScheme(const String&);
> > > > +        virtual void* handleScheme(const KURL, String&, size_t*);
> > > > +#endif
> > > Why would these functions be EFL-specific?  I don't think these make sense >here.
> > 
> > The others ports don't need it, they can do that using their own network library
> > 
> > > 
> > > > WebCore/platform/network/soup/ResourceHandleSoup.cpp:131
> > > > +#if PLATFORM(EFL)
> > > > +static bool startPersonalHandler(ResourceHandle* handle, KURL url);
> > > > +#endif
> > > Adding EFL ifdefs to ResourceHandleSoup isn't the right approach.
> > 
> 
> Personal x Custom (?)

I think "custom" is better than "personal". I'm going to change the patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.