[Webkit-unassigned] [Bug 44759] [EFL] Add custom network resource handler

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44759





--- Comment #4 from Flavio Ceolin <flavio.ceolin at profusion.mobi>  2010-09-01 07:12:33 PST ---
(In reply to comment #3)
> (From update of attachment 65700 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=65700&action=prettypatch
> 
> > WebCore/loader/FrameLoader.cpp:3523
> > +#if PLATFORM(EFL)
> > +bool FrameLoaderClient::shouldHandleScheme(const String& scheme)
> > +{
> > +    return false;
> > +}
> > +
> > +void* FrameLoaderClient::handleScheme(const KURL url, String& mime, size_t* bytesRead)
> > +{
> > +    return 0;
> > +}
> > +#endif
> These implementations are misplaced.  Why are you putting FrameLoaderClient >impls in FrameLoader.cpp?

Because the base class FrameLoaderClient was defined in this file,  moreover there is no file named FrameLoaderClient.cpp. I can do these methods inline inside FrameLoaderClient.h, do you think is it better ?

> 
> > WebCore/loader/FrameLoaderClient.h:271
> > +#if PLATFORM(EFL)
> > +        virtual bool shouldHandleScheme(const String&);
> > +        virtual void* handleScheme(const KURL, String&, size_t*);
> > +#endif
> Why would these functions be EFL-specific?  I don't think these make sense >here.

The others ports don't need it, they can do that using their own network library

> 
> > WebCore/platform/network/soup/ResourceHandleSoup.cpp:131
> > +#if PLATFORM(EFL)
> > +static bool startPersonalHandler(ResourceHandle* handle, KURL url);
> > +#endif
> Adding EFL ifdefs to ResourceHandleSoup isn't the right approach.

Interesting, Do you think is better without ifdefs ?

Thanks for the advices.

Regards, Ceolin

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.