[Webkit-unassigned] [Bug 48321] [NRWT] Fix http lock on Windows platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48321


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71875|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #3 from Tony Chang <tony at chromium.org>  2010-10-26 12:38:35 PST ---
(From update of attachment 71875)
View in context: https://bugs.webkit.org/attachment.cgi?id=71875&action=review

> WebKitTools/Scripts/webkitpy/layout_tests/port/http_lock.py:78
> +        FIXME: On Windows it's always return True."""
> +        if sys.platform in ('darwin', 'linux2'):
> +            try:
> +                os.kill(current_pid, 0)

In webkitpy/common/system/executive.py, there's a kill_process function that should work on windows.  Can we use that instead?

> WebKitTools/Scripts/webkitpy/layout_tests/port/http_lock.py:108
> +                if sys.platform in ('darwin', 'linux2'):
> +                    guard_lock_flags |= os.O_NONBLOCK

Should we add 'cygwin' to the platform tuple?  It looks like cygwin python has os.O_NONBLOCK, although I'm not sure if it does anything.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.