[Webkit-unassigned] [Bug 48321] [NRWT] Fix http lock on Windows platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48321





--- Comment #4 from Dirk Pranke <dpranke at chromium.org>  2010-10-26 12:43:47 PST ---
(In reply to comment #3)
> (From update of attachment 71875 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=71875&action=review
> 
> > WebKitTools/Scripts/webkitpy/layout_tests/port/http_lock.py:78
> > +        FIXME: On Windows it's always return True."""
> > +        if sys.platform in ('darwin', 'linux2'):
> > +            try:
> > +                os.kill(current_pid, 0)
> 
> In webkitpy/common/system/executive.py, there's a kill_process function that should work on windows.  Can we use that instead?
>

No. That routine actually kills the process. This routine is just probing the process to see if it's alive. Frankly, I'm not a fan of using kill -0 to do that, but there doesn't seem to be an alternative that doesn't require shelling out to ps or invoking WMI on windows.

> > WebKitTools/Scripts/webkitpy/layout_tests/port/http_lock.py:108
> > +                if sys.platform in ('darwin', 'linux2'):
> > +                    guard_lock_flags |= os.O_NONBLOCK
> 
> Should we add 'cygwin' to the platform tuple?  It looks like cygwin python has os.O_NONBLOCK, although I'm not sure if it does anything.

I doubt it does anything.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.