[Webkit-unassigned] [Bug 48321] [NRWT] Fix http lock on Windows platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48321





--- Comment #2 from Dirk Pranke <dpranke at chromium.org>  2010-10-26 12:34:35 PST ---
(From update of attachment 71875)
View in context: https://bugs.webkit.org/attachment.cgi?id=71875&action=review

LGTM with the comment fixed as per below.

> WebKitTools/Scripts/webkitpy/layout_tests/port/http_lock.py:75
> +        FIXME: On Windows it's always return True."""

Nit: I'd rewrite this as "FIXME: os.kill() doesn't work on Windows for checking if a pid is alive, so always return True"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.