[Webkit-unassigned] [Bug 39854] Refactor platform dependent editing behavior code out of Settings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39854





--- Comment #8 from Ojan Vafai <ojan at chromium.org>  2010-05-28 09:55:14 PST ---
(In reply to comment #7)
> > -        // We hit this case for Mac behavior when the Y coordinate is below the last box.
> > -        ASSERT(!useWindowsBehavior);
> > +        // We hit this case for non Windows behavior when the Y coordinate is below the last box.
> > +        ASSERT(moveCaretToBoundary);
> 
> I think it's OK, and clearer, for the comment to call this "Mac behavior".

In this specific case, once we add Linux behavior in, it will apply to Mac and Linux. But in that case we could just change "Mac" to "Mac/Linux".

> It's so annoying that Document::settings() can return 0. Maybe we should have a getter on Document that returns the editing behavior directly instead of always having to go via settings.

This sounds great! The null-checks are super-annoying.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.