[Webkit-unassigned] [Bug 39854] Refactor platform dependent editing behavior code out of Settings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39854





--- Comment #9 from Darin Adler <darin at apple.com>  2010-05-28 10:12:50 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > > -        // We hit this case for Mac behavior when the Y coordinate is below the last box.
> > > -        ASSERT(!useWindowsBehavior);
> > > +        // We hit this case for non Windows behavior when the Y coordinate is below the last box.
> > > +        ASSERT(moveCaretToBoundary);
> > 
> > I think it's OK, and clearer, for the comment to call this "Mac behavior".
> 
> In this specific case, once we add Linux behavior in, it will apply to Mac and Linux. But in that case we could just change "Mac" to "Mac/Linux".

Right, but I think even if the comment says "the Mac behavior" it's OK if it's actually used on more platforms than just Mac.

> > It's so annoying that Document::settings() can return 0. Maybe we should have a getter on Document that returns the editing behavior directly instead of always having to go via settings.
> 
> This sounds great! The null-checks are super-annoying.

Maybe Editor is the right object to put this on, rather than Document, though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.