[Webkit-unassigned] [Bug 39854] Refactor platform dependent editing behavior code out of Settings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39854





--- Comment #7 from Darin Adler <darin at apple.com>  2010-05-28 08:59:25 PST ---
(From update of attachment 57331)
> +    bool moveCaretToBoundary = settings && settings->shouldMoveCaretToBoundary();

This will need to have a longer name like:

    shouldMoveCaretToHorizontalBoundaryWhenPastTopOrBottom

Maybe not that exact name, but one more like it.

> -        // We hit this case for Mac behavior when the Y coordinate is below the last box.
> -        ASSERT(!useWindowsBehavior);
> +        // We hit this case for non Windows behavior when the Y coordinate is below the last box.
> +        ASSERT(moveCaretToBoundary);

I think it's OK, and clearer, for the comment to call this "Mac behavior".

It's so annoying that Document::settings() can return 0. Maybe we should have a getter on Document that returns the editing behavior directly instead of always having to go via settings.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.