[Webkit-unassigned] [Bug 39123] Unneeded fillRect call in RenderBoxModelObject::paintFillLayerExtended

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39123





--- Comment #3 from Pat Galizia <pgalizia at codeaurora.org>  2010-05-17 06:22:11 PST ---
(In reply to comment #2)
> (From update of attachment 56084 [details])
> > +                if (!(bgColor.isValid() && (bgColor.alpha() == 0xff))) {
> 
> There's no need to check isValid here. Invalid colors have an alpha of 0.
> 

Okay -- I'll remove that.

> > +                    context->save();
> > +                    context->setCompositeOperation(CompositeCopy);
> > +                    context->fillRect(rect, baseColor, style()->colorSpace());
> > +                    context->restore();
> 
> Since this is a performance optimization, the data we need is how it affects performance. Have you measured faster speed in page rendering?

This was part of a larger series of changes done for Chromium.  I'll capture measurements for this change by itself.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.