[Webkit-unassigned] [Bug 39123] Unneeded fillRect call in RenderBoxModelObject::paintFillLayerExtended

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39123





--- Comment #4 from Pat Galizia <pgalizia at codeaurora.org>  2010-05-19 14:38:48 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 56084 [details] [details])
> > Since this is a performance optimization, the data we need is how it affects performance. Have you measured faster speed in page rendering?
> 
> This was part of a larger series of changes done for Chromium.  I'll capture measurements for this change by itself.

Ran the Chromium browser (using local snapshots of various pages with the Chromium Benchmark extension) showed minimal change -- well within the margin of error.

We then instrumented that block of code to measure the average execution time with and without the patch.  There was an improvement seen, but if depended on the particular webpage loaded (of course).

For example, cnn.com and apple.com page loads saw more improvement (1.7ms and 1.2ms respectively for that block), while sites like netflix.com and yahoo.com saw less (0.7ms and 0.1ms on average) on our 1GHz ARM device.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.