[Webkit-unassigned] [Bug 39123] Unneeded fillRect call in RenderBoxModelObject::paintFillLayerExtended

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39123





--- Comment #2 from Darin Adler <darin at apple.com>  2010-05-14 11:20:26 PST ---
(From update of attachment 56084)
> +                if (!(bgColor.isValid() && (bgColor.alpha() == 0xff))) {

There's no need to check isValid here. Invalid colors have an alpha of 0.

> +                    context->save();
> +                    context->setCompositeOperation(CompositeCopy);
> +                    context->fillRect(rect, baseColor, style()->colorSpace());
> +                    context->restore();

Since this is a performance optimization, the data we need is how it affects performance. Have you measured faster speed in page rendering?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.