[Webkit-unassigned] [Bug 38718] test-webkitpy fails under cygwin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38718





--- Comment #12 from Eric Seidel <eric at webkit.org>  2010-05-07 09:59:41 PST ---
(In reply to comment #11)
> I don't really buy that it makes sense to put these here. This is just test
> data really. Anyone messing with this code will need to look at the tests as
> well. Anyways, not a big deal if you feel strongly.

I don't feel strongly.  But it's difficult to test those constants because they
require testing on multiple platforms.  So I felt like putting them closer to
the implementation might make them less likely to be changed to be wrong.

> > +        while retries_left:
> > +            try:
> > +                retries_left -= 1
> > +                os.kill(pid, signal.SIGKILL)
> > +            except OSError, e:
> > +                if e.errno == errno.EAGAIN:
> > +                    continue
> 
> Maybe we should raise if we get here and retries_left is 0? We should at least
> log something.

To prevent us from infinite looping you mean?  I can make it while retries_left
> 0.

> > +                if e.errno == errno.ESRCH:  # The process does not exist.
> > +                    # FIXME: We should make non-silent failure an option.
> > +                    return

Sure, we could log.  The code which this function was based on assumed it was
silent, but not in a "break it if it isn't silent" kind of way.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.