[Webkit-unassigned] [Bug 38718] test-webkitpy fails under cygwin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38718





--- Comment #13 from Ojan Vafai <ojan at chromium.org>  2010-05-07 10:06:29 PST ---
> > > +        while retries_left:
> > > +            try:
> > > +                retries_left -= 1
> > > +                os.kill(pid, signal.SIGKILL)
> > > +            except OSError, e:
> > > +                if e.errno == errno.EAGAIN:
> > > +                    continue
> > 
> > Maybe we should raise if we get here and retries_left is 0? We should at least
> > log something.
> 
> To prevent us from infinite looping you mean?  I can make it while retries_left
> > 0.

No. Does this mean something went wrong? I'm just saying we should log this as
it ought to be useful debugging when stuff goes wrong.

> > > +                if e.errno == errno.ESRCH:  # The process does not exist.
> > > +                    # FIXME: We should make non-silent failure an option.
> > > +                    return
> 
> Sure, we could log.  The code which this function was based on assumed it was
> silent, but not in a "break it if it isn't silent" kind of way.

Yeah, seems like we should log in cases where things go wrong. This is an
unexpected case, right?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.