[Webkit-unassigned] [Bug 38718] test-webkitpy fails under cygwin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38718





--- Comment #11 from Ojan Vafai <ojan at chromium.org>  2010-05-07 09:46:52 PST ---
> +++ b/WebKitTools/Scripts/webkitpy/common/system/executive.py
> @@ -33,6 +33,7 @@ try:
> +    # Executive unit tests uses this information to validate that
> +    # kill_process/kill_all work as expected an cause the expected exit codes.
> +    # We store this information in this file to keep it next to the platform ifs.
> +    # taskkill.exe causes processes to exit 0, otherwise processes exit -SIGNAL
> +    _KILL_PROCESS_KILLED_PROCESS_EXIT_CODE = 0 if sys.platform == "windows" else -signal.SIGKILL
> +    _KILL_ALL_KILLED_PROCESS_EXIT_CODE = 0 if sys.platform in ("windows", "cygwin") else -signal.SIGTERM

I don't really buy that it makes sense to put these here. This is just test
data really. Anyone messing with this code will need to look at the tests as
well. Anyways, not a big deal if you feel strongly.

> +        while retries_left:
> +            try:
> +                retries_left -= 1
> +                os.kill(pid, signal.SIGKILL)
> +            except OSError, e:
> +                if e.errno == errno.EAGAIN:
> +                    continue

Maybe we should raise if we get here and retries_left is 0? We should at least
log something.

> +                if e.errno == errno.ESRCH:  # The process does not exist.
> +                    # FIXME: We should make non-silent failure an option.
> +                    return

I'm missing something, why can't we just log here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.