[Webkit-unassigned] [Bug 36394] Include git commits in the diff for webkit-patch upload/land.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 29 05:38:39 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=36394





--- Comment #26 from Adam Roben (aroben) <aroben at apple.com>  2010-03-29 05:38:38 PST ---
(In reply to comment #20)
> I know I'm in the minority, but I don't want webkit-patch squashing my commits
> or otherwise modifying my git repository, other than to update placeholders for
> reviewers (or bug numbers) before it lands local commits individually.
> 
> If I wanted commits squashed, I will do it myself.  Likewise I wouldn't have
> local changes when running webkit-patch--I would have committed them (usually
> on a branch) before I ran the command.  I tend to have multiple patches in
> progress on different branches in my git repo, so local changes don't make much
> sense in that scenario.

My workflow sounds very similar to Dave's. Count me in to the minority!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list