[Webkit-unassigned] [Bug 36394] Include git commits in the diff for webkit-patch upload/land.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36394





--- Comment #27 from Chris Jerdonek <cjerdonek at webkit.org>  2010-03-29 08:42:33 PST ---
(In reply to comment #24)
> When you have a branch with multiple patches in it, do you really get the
> reviews all lined up for each patch such that you can "git svn dcommit" the
> whole branch?

I've never done this.  It's probably more trouble than it's worth.

> Or do you split it out into multiple independent submissions
> somehow when it comes time to commit some piece?

I make one branch per bug.  I create each branch as soon as I know it will be
separate, so it will already be split out by the time it comes to committing. 
For example, I might create--

A
A-B

and submit A and B separately for review (in different bug reports).

After landing A, I will "git svn rebase" A-B and land B (or resubmit B if it
hasn't been reviewed yet).  Rarely do I do more than 2 or 3 serial patches this
way.  Of course, it's better if you can structure your work so patches can be
committed independently of one another, and then you can avoid this process. 
But that is not always possible.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.