[Webkit-unassigned] [Bug 36394] Include git commits in the diff for webkit-patch upload/land.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36394





--- Comment #25 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2010-03-29 04:20:42 PST ---
(In reply to comment #24)
> When you have a branch with multiple patches in it, do you really get the
> reviews all lined up for each patch such that you can "git svn dcommit" the
> whole branch?  Or do you split it out into multiple independent submissions
> somehow when it comes time to commit some piece?

No, I create one branch per bug.  Sometimes I want to do some refactoring
before the actual bug is fixed, so I create a series of commits on a branch. 
It makes reviewing the changes a lot easier if they are split into smaller,
logical pieces.  Most recently for Bug 36560, I had two patches.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.