[Webkit-unassigned] [Bug 38661] Persist V8's ScriptData to cache

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38661


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |levin at chromium.org




--- Comment #27 from David Levin <levin at chromium.org>  2010-06-14 23:34:13 PST ---
(In reply to comment #26)
> This has happened to me a couple of other times. If the rest of the class has improper indentation then check-webkit-style complains about a new addition that follows the current style of the class.

True.

> For future reference, I'm wondering if it is acceptable to submit a separate patch that fixes the indentation error for a whole class or if that messes with revision history too much.

Sounds fine to me.

> Alternatively, would it be possible to modify check-webkit-style to not complain in this case if the rest of the class is indented improperly?

We did one fix in this direction. It only complains if the first line in the namespace is indented improperly so this doesn't fire too often but it still does go off at time like this. Sorry.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.