[Webkit-unassigned] [Bug 38661] Persist V8's ScriptData to cache

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 14 13:41:24 PDT 2010


--- Comment #26 from Tony Gentilcore <tonyg at chromium.org>  2010-06-14 13:41:22 PST ---
(In reply to comment #25)
> Attachment 58694 [details] did not pass style-queue:
> Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
> WebCore/bindings/v8/V8Proxy.h:56:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
> Total errors found: 1 in 8 files
> If any of these errors are false positives, please file a bug against check-webkit-style.

This has happened to me a couple of other times. If the rest of the class has improper indentation then check-webkit-style complains about a new addition that follows the current style of the class.

For future reference, I'm wondering if it is acceptable to submit a separate patch that fixes the indentation error for a whole class or if that messes with revision history too much.

Alternatively, would it be possible to modify check-webkit-style to not complain in this case if the rest of the class is indented improperly?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list