[Webkit-unassigned] [Bug 38661] Persist V8's ScriptData to cache

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38661





--- Comment #28 from David Levin <levin at chromium.org>  2010-06-14 23:43:25 PST ---
(From update of attachment 58694)
A few minor things that would be nice to clean up.

WebCore/ChangeLog:13
 +          originally submitted (before it had to be rolled back.
You're missing a closing ) here.

WebCore/bindings/v8/V8Proxy.cpp:34
 +  #include "CachedMetadata.h"
This header is out of order. (case sensitive sorting and 'a' > 'S').


WebCore/bindings/v8/V8Proxy.cpp:358
 +      v8::ScriptData* scriptData = v8::ScriptData::PreCompile(code);
imo, ideally this would be an OwnPtr<> even though it is returned in two lines. (Code tends to grow over time and then people add early returns without realizing that there is something to be cleaned up.)

WebCore/bindings/v8/V8Proxy.h:289
 +          static v8::Handle<v8::Script> compileScript(v8::Handle<v8::String> code, const String& fileName, int baseLine, v8::ScriptData* scriptData = 0);
The param name "scriptData" shouldn't be here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.