[Webkit-unassigned] [Bug 39972] Fix style errors of dtoa

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39972





--- Comment #5 from Kent Tamura <tkent at chromium.org>  2010-06-01 01:24:29 PST ---
(In reply to comment #4)
> I see. So, we should fix rounded_product and rounded_quotient as well?

Yes, we should.  But I didn't change them because I thought they could be member functions of type U.

> I guess we can use reference if there are no performance regression (I'm guessing the compiler is clever enough)?
> 
> static ALWAYS_INLINE void storeInc(uint32_t*& p, uint16_t high, uint16_t low)
> {
>   // ...
>   p++;
> }

I don't like to change to the reference unless you have a strong objection.  I believe returning updated pointer has better code readability.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.