[Webkit-unassigned] [Bug 39972] Fix style errors of dtoa

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 1 01:09:56 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=39972





--- Comment #4 from Shinichiro Hamaji <hamaji at chromium.org>  2010-06-01 01:09:56 PST ---
> It's also a style fix though check-webkit-style doesn't complain it.
> 
> http://webkit.org/coding/coding-style.html
> > 11. Prefer const to #define. Prefer inline functions to macros.

I see. So, we should fix rounded_product and rounded_quotient as well?

I guess we can use reference if there are no performance regression (I'm guessing the compiler is clever enough)?

static ALWAYS_INLINE void storeInc(uint32_t*& p, uint16_t high, uint16_t low)
{
  // ...
  p++;
}

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list