[Webkit-unassigned] [Bug 39972] Fix style errors of dtoa

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 1 01:30:03 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=39972


Shinichiro Hamaji <hamaji at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57498|review?                     |review+
               Flag|                            |




--- Comment #6 from Shinichiro Hamaji <hamaji at chromium.org>  2010-06-01 01:30:02 PST ---
(From update of attachment 57498)
> I don't like to change to the reference unless you have a strong objection.  I believe returning updated pointer has better code readability.

Hmm I slightly prefer the reference so that we won't forget to assign the return value, but it's not a strong objection. Please feel free to land this patch as is.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list