[Webkit-unassigned] [Bug 41607] DeviceOrientationEvent should use optional properties

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41607





--- Comment #9 from Steve Block <steveblock at google.com>  2010-07-12 07:01:47 PST ---
> LayoutTests/fast/dom/DeviceOrientation/script-tests/optional-event-properties.js:39
>  +  event.initDeviceOrientationEvent("", false, false, null, null, null);
> if you used evalAndLog, then this would be printed to the console too, so it'd be easier to read without much additional effort.
OK, will do

> WebCore/dom/DeviceOrientation.h:53
>  +      DeviceOrientation()
> There's enough code here I'd lean towards putting it in a .cpp file.
OK

> WebCore/bindings/js/JSDeviceOrientationEventCustom.cpp:2
>  +   * Copyright 2010, The Android Open Source Project
> Since these contributions are for sure from Google, should the copyright just read Google?
All of the other DeviceOrientation patches are copyright Android, so I think it's best to stick with this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.