[Webkit-unassigned] [Bug 41607] DeviceOrientationEvent should use optional properties

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41607





--- Comment #10 from Jeremy Orlow <jorlow at chromium.org>  2010-07-12 07:09:50 PST ---
(In reply to comment #9)
> > LayoutTests/fast/dom/DeviceOrientation/script-tests/optional-event-properties.js:39
> >  +  event.initDeviceOrientationEvent("", false, false, null, null, null);
> > if you used evalAndLog, then this would be printed to the console too, so it'd be easier to read without much additional effort.
> OK, will do
> 
> > WebCore/dom/DeviceOrientation.h:53
> >  +      DeviceOrientation()
> > There's enough code here I'd lean towards putting it in a .cpp file.
> OK
> 
> > WebCore/bindings/js/JSDeviceOrientationEventCustom.cpp:2
> >  +   * Copyright 2010, The Android Open Source Project
> > Since these contributions are for sure from Google, should the copyright just read Google?
> All of the other DeviceOrientation patches are copyright Android, so I think it's best to stick with this.

Theres no reason the copyright needs to match.  There also is no strong reason why it needs to be Google rather than the android project beyond the former being closer to WebKit's conventions and the typical reasons for having the latter don't apply in this case (unless there's copied code...?).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.