[Webkit-unassigned] [Bug 33178] Segmented SharedBuffer: SharedBuffer doesn't have to be a flat memory block

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33178


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45830|review?                     |review+
               Flag|                            |




--- Comment #13 from Darin Adler <darin at apple.com>  2010-01-04 15:54:05 PST ---
(From update of attachment 45830)
> +static unsigned segmentIndex(unsigned position)
> +{
> +    return position / segmentSize;
> +}
> +
> +static unsigned offsetInSegment(unsigned position)
> +{
> +    return position & segmentPositionMask;
> +}

Should probably say "inline" in both of these.

> +unsigned SharedBuffer::getSomeData(const char*& someData, unsigned pos) const

Would prefer "position" or "offset" to "pos".

r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.