[Webkit-unassigned] [Bug 33178] Segmented SharedBuffer: SharedBuffer doesn't have to be a flat memory block

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33178





--- Comment #14 from Yong Li <yong.li.webkit at gmail.com>  2010-01-05 06:51:37 PST ---
(In reply to comment #13)
> (From update of attachment 45830 [details])
> > +static unsigned segmentIndex(unsigned position)
> > +{
> > +    return position / segmentSize;
> > +}
> > +
> > +static unsigned offsetInSegment(unsigned position)
> > +{
> > +    return position & segmentPositionMask;
> > +}
> 
> Should probably say "inline" in both of these.
> 
> > +unsigned SharedBuffer::getSomeData(const char*& someData, unsigned pos) const
> 
> Would prefer "position" or "offset" to "pos".
> 
> r=me

Thanks! I'll fix these before committing it

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.