[Webkit-unassigned] [Bug 33178] Segmented SharedBuffer: SharedBuffer doesn't have to be a flat memory block

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 4 15:52:01 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=33178





--- Comment #12 from Darin Adler <darin at apple.com>  2010-01-04 15:52:01 PST ---
(In reply to comment #8)
> Still not sure why it will less efficient. Even just merging into a flat
> consecutive buffer at last can still save memory copy times.

OK.

> Also it shouldn't
> be difficult to make image decoding work on segments, because the resource from
> network comes in fragments, and a browser should always be able to decode
> incomplete image source and be able to continue unfinished decoding job when
> more data comes.

Yes, I agree. We just have to do it! And in the mean time I don't want things
to be worse than before. You've convinced me.

> But Vector doesn't call tryFastMalloc, instead, it calls fastMalloc in
> allocateBuffer(). Have I missed anything?

You're right!

I am puzzled, now, by all the places in Vector's code where it says:

    if (!begin())
        return;

I thought those were out-of-memory checks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list