[Webkit-unassigned] [Bug 35087] New port: EFL; adding files to WebCore/*/efl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35087





--- Comment #15 from Gustavo Sverzut Barbieri <barbieri at profusion.mobi>  2010-02-19 02:58:59 PST ---
(In reply to comment #14)
> By and large these patches look okay.  My real concern is the degree of direct
> copying of code rather than reuse of a shared implementation.  I think for the
> most part that's what will need to be fixed in order to get this landed.

Yes, we noticed this. We actually improved a bit over the initial port done by
INdT, but after some time it was not so simple to detect what was copied and
just renamed and what was actually changed and how -- thus we still have couple
of functions as you mentioned.

It is in our plans to progressively improve the whole thing by progressively
merging with Gtk, renaming from "*Gtk.{cpp,h}" to Cairo or related. This way we
avoid the burden we have been taking for a while, benefiting when API changes
and not need to hunt the changes in our side.

Our hope is to get the files included and take part in the process as soon as
possible. Later on apply such changes that may impact other ports (Gtk)
directly, as they will need to take action and patches may hang in bugzilla for
long time, requiring lots of work to keep it updated :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.