[Webkit-unassigned] [Bug 35087] New port: EFL; adding files to WebCore/*/efl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35087


Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48995|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #14 from Oliver Hunt <oliver at apple.com>  2010-02-18 23:05:23 PST ---
(From update of attachment 48995)
static HashMap<String, String> cookieJar;

In general we try to avoid raw globals in WebKit as they cause problems on some
platforms (eg. windows) when loading webkit as a library.  But that's not too
much of an issue (especially given eventually this should be replaced by a
better, persistent storage)

class Cursors {
protected:
     Cursors()
         : PointerCursor("cursor/pointer"),
...
The comma should be at the beginning of the next line rather than the end of
the current

It looks like KeyboardCodes, KeyboardCodeMIMETypeRegistry are also candidates
for refactoring to allow multiple ports to share code, which it is probably
worth looking at before landing these patches, as otherwise the unshared code
is unlikely to ever become shared.

RenderTheme implementation has a lot of incorrect style usage, ( for a call
always goes after the function, not on the next line.

By and large these patches look okay.  My real concern is the degree of direct
copying of code rather than reuse of a shared implementation.  I think for the
most part that's what will need to be fixed in order to get this landed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.